Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TUTORIAL: Add "vatin" to standard fields #524

Merged
merged 2 commits into from
Nov 4, 2023
Merged

TUTORIAL: Add "vatin" to standard fields #524

merged 2 commits into from
Nov 4, 2023

Conversation

rmilecki
Copy link
Collaborator

@rmilecki rmilecki commented Sep 2, 2023 

In most countries end customers pay a VAT (value-added tax). Companies
issuing invoices with VAT need to have a unique identification number
assigned. Local names and abbreviations of those numbers differ across
countries (UID, DIČ, CVR, CBL, NIP, NIF, etc.).

European Union seems to reference those numbers as "VAT identification
numbers". Some open projects like Wikipedia and OpenStreetMap use
"vatin" abbreviation for it. Add field of the same name to the TUTORIAL.

@rmilecki
Copy link
Collaborator Author

rmilecki commented Sep 2, 2023

@bosd
Copy link
Collaborator

bosd commented Sep 2, 2023

Thanks for this PR.
Yet, currently the name vat is in use for this purpose.
At least in the templates contributed by me and alexis-via.

We use this number as the first method of matching the parsed invoice with the partner in the accounting software.

It appears this is one of the undocumented items of this module.
Is it ok to use the name vat?

@bosd
Copy link
Collaborator

bosd commented Sep 2, 2023

On a invoice there are generally 2 VAT numbers as required by law of some EU countries.
One is the vat number of the issuer, the other is of the receipient.

For the recipient vat number we use:

fieldname type Description
company_vat char The vat number of the company to which the invoice is addressed to. Used to check if the invoice is actually is adressed to the company which wants to process it. (Very useful in multi-company setup)

bosd
bosd requested changes Oct 7, 2023
View reviewed changes
TUTORIAL.md Outdated Show resolved Hide resolved
@bosd
Copy link
Collaborator

bosd commented Oct 31, 2023

Ping @rmilecki

Rafał Miłecki and others added 2 commits November 4, 2023 19:46
@bosd
TUTORIAL: Add "vatin" to standard fields
1ce82cc 
In most countries end customers pay a VAT (value-added tax). Companies
issuing invoices with VAT need to have a unique identification number
assigned. Local names and abbreviations of those numbers differ across
countries (UID, DIČ, CVR, CBL, NIP, NIF, etc.).

European Union seems to reference those numbers as "VAT identification
numbers". Some open projects like Wikipedia and OpenStreetMap use
"vatin" abbreviation for it. Add field of the same name to the TUTORIAL.

Signed-off-by: Rafał Miłecki <[email protected]>
@bosd
TUTORIAL: Add "vat" to standard fields
1aa29f9
bosd
bosd approved these changes Nov 4, 2023
View reviewed changes
Copy link
Collaborator

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the field to vat as used in majority of templates.

@bosd bosd merged commit d8fcf43 into invoice-x:master Nov 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosd bosd bosd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmilecki @bosd